-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapper for shell binaries does not handle signals #12164
Comments
The binary proxies in vendor/bin/.. are not wrapper processes, they are just php scripts including the original file, so that should not cause any problems in terms of signal handling. I assume the problem you see is when using composer scripts to run a binary via a script handler? |
Sorry I had a look at the drush issue, and I have more context now, so my question there would be.. why isn't it the bin/drush not just a php script? Because I'd think if you use But anyway we probably should fix it if it's borked, I'll need to investigate this some more and try to repro it though. |
@Seldaek drush ships a shell-script (https://github.com/drush-ops/drush/blob/13.x/drush) as primary entrypoint. Its only task is to disable xdebug ( Afaik its not possible to do it in php, because the env var needs to be present before the php-process is started. |
Currently the shell wrapper starts a sub-process for the original binary. The can mess POSIX signal handling.
Can it use
source
orexec
instead?Also wonder if there is a way to install package binaries without wrappers.
Ref:
drush-ops/drush#6137
The text was updated successfully, but these errors were encountered: