Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code QA : add declare_strict_types if necessary and remove unused import #144

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

llaville
Copy link
Contributor

All Submissions:

Enhance code

Add new rules to PHP CS Fixer config file to ensure code follows CS defined by the project.

Run PHP CS Fixer on code base (commit 0691215)

php php-cs-fixer.phar fix --dry-run -v --allow-risky=yes
PHP CS Fixer 3.50.0 (8794475) Insomnia by Fabien Potencier, Dariusz Ruminski and contributors.
PHP runtime: 8.2.16
Loaded config default from "/shared/backups/forks/symbol-parser/.php-cs-fixer.dist.php".
Using cache file ".php-cs-fixer.cache".
 60/60 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

   1) src/Parser/PHP/Strategy/UsedExtensionSymbolStrategy.php (declare_strict_types, blank_line_after_opening_tag)
   2) src/Parser/PHP/Strategy/UseStrategy.php (no_unused_imports)
   3) src/Parser/PHP/Strategy/PhpExtensionStrategy.php (declare_strict_types, blank_line_after_opening_tag)

Fixed 3 of 60 files in 0.263 seconds, 18.711 MB memory used

@icanhazstring icanhazstring merged commit ffb1de0 into composer-unused:main Feb 24, 2024
10 checks passed
@llaville llaville deleted the qa/cs-fixes branch February 24, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants