Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop all comments from yaml file before applying string substitutions #158

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Jul 22, 2021

@ndeloof ndeloof force-pushed the substitute_comments branch from 32fbf08 to b58f103 Compare July 22, 2021 09:40
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof force-pushed the substitute_comments branch from b58f103 to 2747bbf Compare July 22, 2021 09:48
Copy link
Contributor

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit 6e1e1c2 into compose-spec:master Jul 22, 2021
@ndeloof ndeloof deleted the substitute_comments branch July 22, 2021 13:00
@ndeloof ndeloof restored the substitute_comments branch September 10, 2021 13:35
@ndeloof ndeloof deleted the substitute_comments branch September 10, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"invalid template" error from certain YAML comments
2 participants