Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(runtime): make Attacher a container #154

Merged
merged 9 commits into from
Nov 26, 2023
Merged

refactor(runtime): make Attacher a container #154

merged 9 commits into from
Nov 26, 2023

Conversation

Berrysoft
Copy link
Member

This is an experimental PR. It tries to force the user of Attacher to attach the source before using it. As a side-effect, compio-fs and compio-net must depend on compio-runtime.

@Berrysoft Berrysoft added enhancement New feature or request package: net Related to compio-net package: fs Related to compio-fs package: runtime Related to compio-runtime refactor Refactoring existing code labels Nov 20, 2023
@Berrysoft Berrysoft self-assigned this Nov 20, 2023
@George-Miao
Copy link
Member

Please change the PR name to refactor

@Berrysoft Berrysoft changed the title feat(runtime): refactor Attacher refactor(runtime): refactor Attacher Nov 24, 2023
@Berrysoft Berrysoft force-pushed the remove-runtime-feature branch from 9f9d1f4 to b69b2a0 Compare November 24, 2023 13:06
@Berrysoft Berrysoft changed the title refactor(runtime): refactor Attacher refactor(runtime): make Attacher a container Nov 24, 2023
@Berrysoft
Copy link
Member Author

I don't know why mac ventura sometimes being cancelled. Let's just ignore it:)

@Berrysoft
fix(runtime): apply suggestions:
01444e7 
update comment of Attacher

make Attacher::new const

Remove constraints on Unattached
George-Miao
George-Miao approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit 97daabe into compio-rs:master Nov 26, 2023
11 checks passed
@Berrysoft Berrysoft deleted the remove-runtime-feature branch November 26, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George-Miao George-Miao George-Miao approved these changes

Assignees

@Berrysoft Berrysoft

Labels
enhancement New feature or request package: fs Related to compio-fs package: net Related to compio-net package: runtime Related to compio-runtime refactor Refactoring existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Berrysoft @George-Miao