Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tls): add native-tls adapters. #119

Merged
merged 10 commits into from
Oct 23, 2023
Merged

feat(tls): add native-tls adapters. #119

merged 10 commits into from
Oct 23, 2023

Conversation

Berrysoft
Copy link
Member

Working on simple TLS support.

@Berrysoft Berrysoft self-assigned this Oct 22, 2023
@Berrysoft Berrysoft marked this pull request as ready for review October 22, 2023 14:42
@Berrysoft Berrysoft requested a review from George-Miao October 22, 2023 14:42
@Berrysoft Berrysoft requested a review from bdbai October 22, 2023 15:54
George-Miao
George-Miao previously approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need more tests.

compio-native-tls/Cargo.toml Outdated Show resolved Hide resolved
compio-native-tls/Cargo.toml Outdated Show resolved Hide resolved
compio-io/src/write/buf.rs Outdated Show resolved Hide resolved
compio-native-tls/src/stream.rs Outdated Show resolved Hide resolved
compio-native-tls/src/stream.rs Outdated Show resolved Hide resolved
compio-net/Cargo.toml Show resolved Hide resolved
compio-io/src/read/buf.rs Show resolved Hide resolved
compio-native-tls/src/adapter.rs Outdated Show resolved Hide resolved
compio-native-tls/src/stream.rs Outdated Show resolved Hide resolved
compio-native-tls/src/stream.rs Outdated Show resolved Hide resolved
@George-Miao George-Miao dismissed their stale review October 22, 2023 17:18

Didn't approve

@George-Miao George-Miao added enhancement New feature or request package: tls Related to compio-tls labels Oct 22, 2023
@Berrysoft Berrysoft requested a review from George-Miao October 23, 2023 05:44
George-Miao
George-Miao approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit 1c5c5e3 into compio-rs:master Oct 23, 2023
@Berrysoft Berrysoft deleted the dev/native-tls branch October 23, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdbai bdbai bdbai left review comments

@George-Miao George-Miao George-Miao approved these changes

Assignees

@Berrysoft Berrysoft

Labels
enhancement New feature or request package: tls Related to compio-tls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Berrysoft @bdbai @George-Miao