-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Python project outline #26
Conversation
@thekaveman if you try to build the dev container it'll fail and you'll prob see this error: I was at least expecting to see I tried to isolate the problem and the container builds fine if I remove "setuptools_scm>=8" from the dev dependencies Line 20 in 8290130
and Line 29 in 8290130
Then from inside the container I can
and I can see that at least the commit shows up in the version string, but the container is failing to build 🤔 |
install devcontainer requirements from pyproject.toml devcontainer updated with TOML VSCode extension __init__.py ready for dynamic package versioning pyproject.toml with project metadata, dependencies, and build system
Currently the .git directory is not available during Docker build time, so setuptools-scm returns an error. Dynamic versioning will be added later.
8290130
to
79cd7b3
Compare
Yep, I think that's the reason, the So I hardcoded If it's ok, I removed all references to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 🐍
Closes #4
This PR prepares the outline for a Python project