Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add write permissions for mkdocs #25

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix: add write permissions for mkdocs #25

merged 1 commit into from
Dec 4, 2024

Conversation

thekaveman
Copy link
Member

Needs write permission to push the gh-pages branch. See failure here: https://github.com/compilerla/pems/actions/runs/12168357388/job/33938992891

I made the default permissions for GitHub Actions in this repo be read.

@thekaveman
fix(ci): add write permissions for mkdocs
a86bf05 
so it can push the gh-pages branch
@thekaveman thekaveman requested a review from a team as a code owner December 4, 2024 21:34
lalver1
lalver1 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@lalver1 lalver1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I noticed some Deprecation Warnings too so I'll try to address those in a separate PR.

@thekaveman thekaveman merged commit 75c870e into main Dec 4, 2024
1 check passed
@thekaveman thekaveman deleted the fix/ci-mkdocs branch December 4, 2024 22:34
@thekaveman thekaveman added this to the Initial project setup milestone Dec 10, 2024
@thekaveman thekaveman added bug Something isn't working documentation Improvements or additions to documentation actions Related to GitHub Actions workflows labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalver1 lalver1 lalver1 approved these changes

Assignees
No one assigned
Labels
actions Related to GitHub Actions workflows bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
Initial project setup
Development

Successfully merging this pull request may close these issues.
2 participants
@thekaveman @lalver1