Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: improve output #117

Merged
merged 10 commits into from
Oct 17, 2024
Merged

Feat: improve output #117

merged 10 commits into from
Oct 17, 2024

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Oct 17, 2024 •
edited
Loading

Closes #81
Closes #109

  • Color in the output is now optional (on by default) with the --no-color arg
  • Default error message is much simpler / shorter
  • Use the --verbose arg to print more information:

maringuu and others added 4 commits October 16, 2024 17:40
@maringuu
feat: Give a hint on how to reedit the commit message
0f77fdc 
I think it is not common knowledge that the commit message is
stored in `.git/COMMIT_EDITMSG` if the hook fails.
Let's give the user a hint and a copy-pastable command to retry the commit.
@thekaveman
feat(output): module to produce CLI messages
95565c2
@thekaveman
refactor(hook): get output from helper functions
beb5c03
@thekaveman
feat(hook): arg for more verbose output
174d446
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  conventional_pre_commit
  format.py
  hook.py
  output.py 83-84
Project Total  

This report was generated by python-coverage-comment-action

@thekaveman thekaveman mentioned this pull request Oct 17, 2024
Closed
@thekaveman thekaveman merged commit fab6a95 into main Oct 17, 2024
6 checks passed
@thekaveman thekaveman deleted the feat/output branch October 17, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message is imprecise and too long colours on non-ansi terminals
2 participants
@thekaveman @maringuu