Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Emscripten-build-instructions.md to match PR in xeus-cpp https://github.com/compiler-research/xeus-cpp/pull/199 #410

Merged

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Dec 22, 2024

Description

Please include a summary of changes, motivation and context for this PR.

This updates the emscripten build instruction to match the PR in xeus-cpp compiler-research/xeus-cpp#199

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me .

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.87%. Comparing base (6cc66be) to head (b4e0ff2).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   70.87%   70.87%           
=======================================
  Files           9        9           
  Lines        3533     3533           
=======================================
  Hits         2504     2504           
  Misses       1029     1029           

@mcbarton mcbarton merged commit 45cd0d1 into compiler-research:main Dec 22, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants