Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase parameter names #27

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Lowercase parameter names #27

merged 1 commit into from
Dec 15, 2021

Conversation

thisFreya
Copy link
Collaborator

A tiny change to parameter names to uniformly lowercase, reflected in simSPI.

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #27 (6fa36fb) into master (6d03b19) will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   94.49%   94.81%   +0.33%     
==========================================
  Files           5        5              
  Lines         308      308              
==========================================
+ Hits          291      292       +1     
+ Misses         17       16       -1     
Impacted Files Coverage Δ
ioSPI/cryoemio.py 97.35% <100.00%> (ø)
ioSPI/fourier.py 100.00% <0.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d03b19...6fa36fb. Read the comment docs.

@thisFreya
Copy link
Collaborator Author

@geoffwoollard tiny changes made to reflect lowercase parameter names in simSPI.

Copy link
Contributor

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thisFreya thisFreya merged commit 212d386 into master Dec 15, 2021
@thisFreya thisFreya deleted the parameter_name_changes branch December 15, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants