-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get CI working, increase test coverage (numba jit) #21
Conversation
Test failing with reading .cif in ioSPI.iotools.atomic_models.read_gemmi_model, so remove test for now. But this is a real bug I think and should be fixed. #22 . @fredericpoitevin can you have a look? |
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
Coverage ? 92.11%
=========================================
Files ? 4
Lines ? 190
Branches ? 0
=========================================
Hits ? 175
Misses ? 15
Partials ? 0 Continue to review full report at Codecov.
|
write_gemmi_model(path_output, model) | ||
model = read_gemmi_model(path_output) | ||
assert model.__class__ is gemmi.Model | ||
# path_input = "2dhb.cif" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we would not leave left-over comments, but I'll merge anyway so that @fredericpoitevin can have a look.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes officer Nina ;)
Hopefully Fred can quickly fix this with his gemmi skills and the comments will be gone in no time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Pick up where this PR left off #19