Fix mlflow health endpoint

Signed-off-by: Burak Ince <burak.ince@linux.org.tr>
community-charts · Jan 17, 2025 · dfe7310 · dfe7310
1 parent de635a0
commit dfe7310
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 11 deletions.
diff --git a/charts/mlflow/Chart.yaml b/charts/mlflow/Chart.yaml
@@ -16,7 +16,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.11.0
+version: 0.12.0
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
@@ -58,7 +58,7 @@ annotations:
       url: https://github.com/burakince/mlflow
   artifacthub.io/containsSecurityUpdates: "false"
   artifacthub.io/changes: |
-    - Fix wrong mounth and auth config path definition
+    - Fix health endpoint
   artifacthub.io/images: |
     - name: mlflow
       image: burakince/mlflow:2.19.0

diff --git a/charts/mlflow/README.md b/charts/mlflow/README.md
@@ -4,7 +4,7 @@
 
 A Helm chart for Mlflow open source platform for the machine learning lifecycle
 
-![Version: 0.11.0](https://img.shields.io/badge/Version-0.11.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.19.0](https://img.shields.io/badge/AppVersion-2.19.0-informational?style=flat-square)
+![Version: 0.12.0](https://img.shields.io/badge/Version-0.12.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.19.0](https://img.shields.io/badge/AppVersion-2.19.0-informational?style=flat-square)
 
 ## Get Helm Repository Info
 

diff --git a/charts/mlflow/templates/_helpers.tpl b/charts/mlflow/templates/_helpers.tpl
@@ -62,3 +62,8 @@ Create the name of the service account to use
 {{- default "default" .Values.serviceAccount.name }}
 {{- end }}
 {{- end }}
+
+{{- define "mlflow.health" -}}
+{{- $basPath := default "/" .Values.extraArgs.staticPrefix }}
+{{- printf "%s/health" ($basPath | trimSuffix "/" )}}
+{{- end }}
diff --git a/charts/mlflow/templates/deployment.yaml b/charts/mlflow/templates/deployment.yaml
@@ -135,14 +135,14 @@ spec:
               protocol: TCP
           livenessProbe:
             httpGet:
-              path: {{ .Values.extraArgs.staticPrefix | default "/" }}
+              path: {{ include "mlflow.health" . }}
               port: {{ .Values.service.name }}
           {{- with .Values.livenessProbe }}
             {{- toYaml . | nindent 12 }}
           {{- end }}
           readinessProbe:
             httpGet:
-              path: {{ .Values.extraArgs.staticPrefix | default "/" }}
+              path: {{ include "mlflow.health" . }}
               port: {{ .Values.service.name }}
           {{- with .Values.readinessProbe }}
             {{- toYaml . | nindent 12 }}

diff --git a/charts/mlflow/unittests/__snapshot__/deployment_test.yaml.snap b/charts/mlflow/unittests/__snapshot__/deployment_test.yaml.snap
@@ -53,7 +53,7 @@ should match snapshot of default values:
               livenessProbe:
                 failureThreshold: 5
                 httpGet:
-                  path: /
+                  path: /health
                   port: http
                 initialDelaySeconds: 10
                 periodSeconds: 30
@@ -66,7 +66,7 @@ should match snapshot of default values:
               readinessProbe:
                 failureThreshold: 5
                 httpGet:
-                  path: /
+                  path: /health
                   port: http
                 initialDelaySeconds: 10
                 periodSeconds: 30
@@ -153,7 +153,7 @@ should match snapshot with additional values:
               livenessProbe:
                 failureThreshold: 5
                 httpGet:
-                  path: /
+                  path: /health
                   port: http
                 initialDelaySeconds: 10
                 periodSeconds: 30
@@ -166,7 +166,7 @@ should match snapshot with additional values:
               readinessProbe:
                 failureThreshold: 5
                 httpGet:
-                  path: /
+                  path: /health
                   port: http
                 initialDelaySeconds: 10
                 periodSeconds: 30

diff --git a/charts/mlflow/unittests/deployment_test.yaml b/charts/mlflow/unittests/deployment_test.yaml
@@ -227,10 +227,10 @@ tests:
     asserts:
       - equal:
           path: spec.template.spec.containers[0].livenessProbe.httpGet.path
-          value: /mlflow
+          value: /mlflow/health
       - equal:
           path: spec.template.spec.containers[0].readinessProbe.httpGet.path
-          value: /mlflow
+          value: /mlflow/health
 
   - it: should check that the db checker init container is present if enabled with postgres
     set: