Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker command java location #420

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

kinow
Copy link
Member

@kinow kinow commented Jun 8, 2022

Description

Found while testing #419 locally. The java executable is located in a different location for the base image we used (my bad, missed that in the update).

Motivation and Context

How Has This Been Tested?

Locally, for #419

Screenshots (if appropriate):

See #419

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kinow kinow marked this pull request as ready for review June 8, 2022 10:51
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This needs a confirmatory test

@mr-c mr-c merged commit f630c20 into common-workflow-language:main Jun 8, 2022
@mr-c
Copy link
Member

mr-c commented Jun 8, 2022

Merging this for now, I made an issue about the test at #421

@kinow kinow deleted the fix-docker-command branch June 8, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants