Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small space between buttons and element under it, and align right #352

Merged
merged 2 commits into from
Sep 30, 2021

Conversation

kinow
Copy link
Member

@kinow kinow commented Sep 30, 2021

Description

Hi, I noticed that the buttons to download images were not aligned to the right. Looking at the HTML attributes and CSS file, looks like there are attributes accidentally swapped.

Motivation and Context

To have everything aligned in the UI layout.

How Has This Been Tested?

Locally running the application in IntelliJ + docker.

Screenshots (if appropriate):

Before:

image

After:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@@ -160,7 +160,7 @@ <h2>Workflow: <span th:text="${workflow.label}">Workflow Name</span></h2>

</div>
<div class="col-lg-3 col-md-4 col-sm-6 hidden-xs">
<div class="graph-menu hidden-print" id="pull-right">
<div class="graph-menu hidden-print" id="graph-menu">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this file to confirm graph-menu is an ID, not a CSS class.

#graph-menu {
margin-bottom: 5px;
}

@mr-c
Copy link
Member

mr-c commented Sep 30, 2021

Thank you @kinow !

@mr-c mr-c merged commit 95fc04d into common-workflow-language:main Sep 30, 2021
@kinow kinow deleted the correct-html-css branch September 30, 2021 08:51
@kinow
Copy link
Member Author

kinow commented Sep 30, 2021

Thank you @mr-c ! I think I forgot to swap the pull-right though 😢 sending another small PR, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants