Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replace non working deleteByRetrievedFrom function with working delete function #321

Merged

Conversation

obasekiosa
Copy link
Contributor

@obasekiosa obasekiosa commented Apr 13, 2021

Description

Replace all occurances of QueuedWorkflowRepository's deleteByRetrievedFrom delete method which performs a read operation(Bug)
with auto-generated deleteByTempRepresentation_RetrievedFrom method.

Also, the current delete method's name convention does not allow for auto-generation of the required delete method.

Motivation and Context

Since the deleteByRetrievedFrom method does not perform a delete operation. queued workflows are never deleted.

Fixes #320
Also a possible fix for Issue #212

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so happy to see this, thank you! Can you please add a test to confirm your fix?

@obasekiosa
Copy link
Contributor Author

I am so happy to see this, thank you! Can you please add a test to confirm your fix?

Alright, I'll start working on that now.

@tetron tetron merged commit 927045d into common-workflow-language:main Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueuedWorkflowRepository's deleteByRetrievedFrom method uses finder queries annotation.
3 participants