Streamable CWL graph images #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. no need for temporary files for parsing YAML
|
This pull request introduces 2 alerts when merging f36ef42 into 3a5c2d0 - view on LGTM.com new alerts:
|
This was referenced Nov 21, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide
InputStreamandPathbased methods for returning fromGraphService, instead of the oldieFileusing temporary files.Motivation and Context
The current implementation has excessive use of temporary files.
This patch will improve #239 by avoiding it making temporary files just to call the methods or return images over HTTP.
How Has This Been Tested?
CWLServiceTestandGraphVizServiceTesthave been updated.Types of changes
Checklist: