Add sendgrid support for single and bulk mail (#5) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcheung
approved these changes
Dec 8, 2020
davidcheung
reviewed
Dec 8, 2020
| @@ -16,7 +16,7 @@ type Config struct { | |||
| var config *Config | |||
|
|
|||
| const ( | |||
| _ = string(iota) // We don't care about the values of these constants | |||
| _ = string(rune(iota)) // We don't care about the values of these constants | |||
There was a problem hiding this comment.
Just curious what does this do?
There was a problem hiding this comment.
It's a way to generate constants that have a specific, unique, but unimportant value. What we're using it for is to be able to refer to config options using a specific const like Port rather than just a string like "port" which allows us to be more precise about our type checking, avoid typos, etc.
I had to add rune in there because something changed in go 1.15 which caused a warning due to the conversion from int directly to string. It doesn't really matter in our situation because, again, the value itself is unimportant, as long as it's a unique string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improved the schema a bit, added support for templated messages, and scheduled sending.