Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add headers support to sendgrid mail #31

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

davidcheung
Copy link
Contributor

ability to specify headers, so can thread messages using in-reply-to and any other headers sendgrid support for SMTP headers

@davidcheung davidcheung requested a review from bmonkman September 6, 2022 19:57
@davidcheung davidcheung requested a review from a team as a code owner September 6, 2022 19:57
@davidcheung davidcheung removed the request for review from bmonkman September 6, 2022 20:37
@bmonkman
Copy link
Contributor

bmonkman commented Sep 6, 2022

For some reason it's appending _inner to a couple models during code generation which is why vet is failing:

[main] INFO  o.o.codegen.InlineModelResolver - Inline schema created as SendBulkMailResponse_successful_inner. To have complete control of the model name, set the `title` field or use the inlineSchemaNameMapping option (--inline-schema-name-mapping in CLI).
[main] INFO  o.o.codegen.InlineModelResolver - Inline schema created as SendBulkMailResponse_failed_inner. To have complete control of the model name, set the `title` field or use the inlineSchemaNameMapping option (--inline-schema-name-mapping in CLI).

@davidcheung
Copy link
Contributor Author

Yeah looks like newer generator generates different code from the API specs, the build-and-push will pull the latest so its different from our dockerfile which uses FROM openapitools/openapi-generator-cli:v5.0.0-beta3 AS generate

@davidcheung davidcheung merged commit e924f54 into main Sep 6, 2022
@davidcheung davidcheung deleted the send-mail-with-headers branch September 6, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants