This repository has been archived by the owner on May 24, 2023. It is now read-only.
Adjustments of the klarna payment process #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahalberkamp
commented
Jan 19, 2022
...va/com/commercetools/pspadapter/payone/domain/payone/model/common/PayoneRequestWithCart.java
Outdated
Show resolved
Hide resolved
…in/payone/model/common/PayoneRequestWithCart.java
leungkinghin-ct
suggested changes
Jan 19, 2022
| @@ -36,7 +36,7 @@ public CreditCardPreauthorizationRequest createPreauthorizationRequest( | |||
| final String pseudocardpan = ctPayment.getCustom().getFieldAsString(CustomFieldKeys.CARD_DATA_PLACEHOLDER_FIELD); | |||
| CreditCardPreauthorizationRequest request = new CreditCardPreauthorizationRequest(getPayoneConfig(), pseudocardpan, paymentWithCartLike); | |||
|
|
|||
| mapFormPaymentWithCartLike(request, paymentWithCartLike); | |||
| mapFormPaymentWithCartLike(request, paymentWithCartLike, false); | |||
There was a problem hiding this comment.
I would prefer to assign this boolean value into a variable called isIgnoreShippingAdress before parsing it into another method, so that developers can quickly identify what true/false represents here.
…-payone-integration into add_workerid
leungkinghin-ct
approved these changes
Jan 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr the final modification was done, to make the Klarna payment working.
-Add required fields "workorderid" to payone-request.