Use const type parameters so author does not need to add "as const" to get narrow types for choices #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: matthyk <53833818+matthyk@users.noreply.github.com>
dda9d7c to
e438926
Compare
abetomo
approved these changes
Nov 2, 2024
|
Thanks @abetomo Very quick! |
Merged
|
A prerelease is available for v13. The release is tagged as next and can be installed with: |
|
Released in v13.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
This is inspired by #61 and goes a bit further.
Reminder to self: have @matthyk as co-author.
Problem
To get narrow types for options and arguments with choices, author needs to add
as constto encourage TypeScript to narrow the type.Solution
TypeScript 5.0 adds const type parameters to use narrow types by default. Use this in particular for
.choices(), but also for.default()and.preset()for consistency when used together.ChangeLog
as const