Strongly typed optsWithGlobals #78
Merged
+373
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40f902d to
c08000c
Compare
dbfe3f2 to
acbc92c
Compare
abetomo
approved these changes
Nov 1, 2024
|
@shadowspawn @abetomo do you know when this will be released? |
|
We don't have a date planned, but I expect by mid-January 2026. Would a pre-release build be useful to you? I have just one more issue I want to look at for a major version of Commander: |
|
Yes please. Would be useful to test it out
…On Fri, 29 Nov 2024, 18:33 John Gee, ***@***.***> wrote:
We don't have a date planned, but I expect by mid-January 2026.
Would a pre-release build be useful to you?
I have just one more issue I want to look at for a major version of
Commander:
- tj/commander.js#2263 <tj/commander.js#2263>
—
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMBRIXBLSTMPFHEN7ADBSD2DCXPPAVCNFSM6AAAAABQVHVRJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBYGI4TCNJRHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
A prerelease is available for v13. The release is tagged as next and can be installed with: |
|
Released in v13.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
.optsWithGlobals()and.getOptionValueSourceWithGlobals()are weakly typed and not using globals.Solution
Add
Command<>generic forGlobalOpts..optsWithGlobals()is strongly typed.getOptionValueSourceWithGlobals()is weakly typed. Get autocompletion for known options, but can enter anything, like with the other...Source...routines.On the way I upgraded eslint because I noticed
@typescript-eslint/ban-typeswas changing to@typescript-eslint/no-empty-object-type. And simplifiedeslint.config.jsto avoid bogus TypeScript errors from.jsfiles. (Apologies for the extra changes. I did make them separate commits.)ChangeLog
.optsWithGlobals()to include inferred globals.getOptionValueSourceWithGlobals()to include inferred globals