set this context for action callback (#59)

commander-js · Feb 12, 2024 · ca47a6b · ca47a6b
1 parent c09ce23
commit ca47a6b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/index.d.ts b/index.d.ts
@@ -691,7 +691,7 @@ export class CommanderError extends Error {
      *
      * @returns `this` command for chaining
      */
-    action(fn: (...args: [...Args, Opts, this]) => void | Promise<void>): this;
+    action(fn: (this: this, ...args: [...Args, Opts, this]) => void | Promise<void>): this;
 
     /**
      * Define option with `flags`, `description`, and optional argument parsing function or `defaultValue` or both.

diff --git a/tests/arguments.test-d.ts b/tests/arguments.test-d.ts
@@ -314,6 +314,16 @@ program
     expectAssignable<OptionValues>(options);
   });
 
+// `this` should be current Command
+program
+  .option('-o, --opt')
+  .option('-v, --verbose')
+  .argument('<arg>')
+  .argument('<second argument>')
+  .action(function () {
+    expectType<Command<[string, string], { opt?: true, verbose?: true }>>(this)
+  })
+
 // default type ignored when arg is required
 expectType<('C')>(
   program