Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safety test: fix incorrect error message #1702

Merged
merged 1 commit into from
Nov 1, 2023
Merged

safety test: fix incorrect error message #1702

merged 1 commit into from
Nov 1, 2023

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Nov 1, 2023 •
edited
Loading

Fix regression from #1579

Attr is always the last attr we loop through, which happens to be unittest due to adding generators and not evaluating the values.

Example:

AssertionError: 1 is not false : transmit of addr=0x2e6 bus=0 from unittest during TestToyotaStockLongitudinalTorque was allowed

Fixed:

AssertionError: 1 is not false : transmit of addr=0x2e6 bus=0 from TestToyotaAltBrakeSafety during TestToyotaStockLongitudinalTorque was allowed

@sshane sshane changed the title don't add a generator safety test: fix incorrect error message Nov 1, 2023
@sshane sshane merged commit 120ea2c into master Nov 1, 2023
@sshane sshane deleted the fix-test-generator-bug branch November 1, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sshane