-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ford: add Edge 2022 #31767
Ford: add Edge 2022 #31767
Conversation
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
|
We've moved the car interfacing code to our PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you. |
Follow up to #30762 since there were conflicts preventing it being merged. (changes one less file!)
FW is from
3d4e31f900dd3a88
(2022 Ford Edge, VIN:2FMPK4J95NBA30321
) and26da1db30eff4fcc
(2022 Ford Edge Titanium but retrofit ACC, VIN:2FMPK4K98NBA52134
)Alternate steering message
I'd also like to double check that there is no other steering angle signal that we can use...SteeringPinion_Data
sent by the PSCM moved to 0x85;StePinComp_An_Est
is not populated (-1600) andStePinCompAnEst_D_Qf
is faulty/not populated (0).BrakeSnData_6
containingStePinOffst_An_Est
is missing (couldn't find the new address if it has moved)ParkAid_Data.ExtSteeringAngleReq2
has an estimated steering angle we can use instead, and the raw values32766
and32767
can be used to detect unknown/invalid state.The
2GC
platform code in the EPS pn/fw is only on the Edge/Nautilus (and Fusion/Continental/MKZ but they can't be supported). (from the Ford FW table)Dependencies
Checklist
selfdrive/car/docs.py
to generate new docs3d4e31f900dd3a88|2023-12-15--11-31-09
(experimental mode:3d4e31f900dd3a88|2023-12-15--11-19-47
)3d4e31f900dd3a88|2023-12-17--16-47-36
Full credit goes to @MikeDoyal for getting this supported and @mikehundley for testing