-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2015-2016 CR-V Touring #98
Comments
The obvious signals i don't see are: "car_gas", "cruise_buttons", "main_on", "cruise_setting", "steer_torque", "steer_torque_request", and "gas_command" |
Does he have a NEO? Connect it up to log can. I know steer torque request moved. |
Not yet |
I have a NEOS, what portion of FCAN can I update to refine the id, byte and bit of the exact steering, braking, gas, etc.., what portion in the C/Python I can modified for different vehicle? What open source software do you guy use to make dbc file? other than Vector tool? I have a neos but need to update for different vehicle. |
Just run the NEO and upload your can data to drive explorer |
Steering looks like 194. Only messages that stop sending (at the OBDII port) when cam is unplugged are:
|
The set speed is on 30C, same as the ilx and civic. This controls gas. So looks like the only change is E4 -> 194 |
And we made the dbc files using a text editor :) |
so I need to change E4-->194 in the dbc file and rename as 15/16 crv touring ? Do I need change the python code "hondacan.py"? You mention drive explorer, the drive explorer on neos phone platform? How can change the control to add learning different drive? Ai Drive change learning? If I can modify to code to allow cruise to below 25mph, then will your system work for city driving? Steering I might not able to change. |
I mention modified the vehicle code to allow cruise control under 25mph |
It's more than that. The message content is different as well. There's no easy way to modify for the higher torques and low speeds required for city driving. And whenever you make modifications, always make sure you are following the safety guidelines in https://github.com/commaai/openpilot/blob/master/SAFETY.md |
in the hondacan.py where does it distinguish for which dbc file. how can I change the lsb, and where is the pointer to point to certain dbc file in this command line? |
Oh, it look like the steering command factor is 1 for 0E4 is ilx? can I change it to more precise lsb factor? and the range is off. how does the following command relate to 0E4? Some value is just 0 or 1, how come range is 127? |
Good news coming soon for this car! |
@energee That's good news! |
Crv have cvt transmission, content same as Civic |
We have a completed dbc, will upstream soon. |
@energee that is great. what is this does? #add 2015-2016 CRV touring I modified carcontroller,carstate and hondacan & make new dbc file. |
sorry why idx = frame % 2? and other one %4? if the lsb of 194 is And does Openpilot have any checksum error if I plug into the car? |
|
@energee is your work for the 2015/16 CRV Touring only ? |
The 15/16 touring is the only CR-V model in these years that has honda sensing. |
@energee @geohot I drive to open the oneplus 3t manually to access drive. But it seen it can't recognize as an android device. Sorry maybe this answer somewhere, but I haven't figure it out. |
Steering working! Just need to fine tune this a bit and port will be complete. |
2015-2016 CRV and 2016 & 2017 Accord is the same system on 4cylinder vehicle. @energee @geohot or is there to install custom openpilot.comma.ai with custom file change to test the code. command line use: |
You can run your own custom code by cloning your fork of openpilot onto the neo. That's what I've done. Just make sure your custom code is in the /data/openpilot directory on the neo. Command is something like this: git clone https://github.com/your/fork.git /data/openpilot You may want to rename the current folder to something first so you can switch back and forth: mv /data/openpilot /data/openpilot.v0.3.2 Granted, this doesn't help you if you can't even SSH into the phone. Sometimes I can't connect to the neo via SSH either. First thing to check is if the IP address of the neo is correct. It may have changed. Can you see the list of DHCP clients on your wifi? |
You can also check the IP address on the Neo. I can't remember exactly
where, but it is somewhere under settings.
My Neo IP address lease just changed today.
John
…On Sun, Jun 11, 2017 at 10:21 PM, pjlao307 ***@***.***> wrote:
You can run your own custom code by cloning your fork of openpilot. That's
what I've done. Just make sure your custom code is in the /data/openpilot
directory on the neo. Granted, this doesn't help you if you can't even SSH
into the phone. Sometimes I can't connect to the neo via SSH either.
First thing to check is if the IP address of the neo is correct. It may
have changed. Can you see the list of DHCP clients on your wifi?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATnNl9ie7W8QTtPxo9LaHo_vq3C0H56hks5sDKC-gaJpZM4Nes73>
.
|
@johnwaynehacker I did not buy a neodriven but you should be able to just reflash it with the most current neo is following the same steps. I did this to mine recently. |
The IP address I can check on the neos. It show the IP address. I wondering if is the key issue or my wifi. |
I own it, but transfer to step sister, but I can borrow and test. I still haven't problem getting neos code to open. Is here any to access one plus 3t without ssh. I'm using a Mac to ssh to it. Unless port forwarding issue on router. I'm haven't check port forwarding on router setting yet. |
latest try by adding port 8022 and 22 ssh net to neos device ip port forwarding. |
I try noticed for the CRV in high wind system, the steering is off most of the time. Also, |
Try adjusting the |
It did that for me as well until I had several hours of driving time down. And every time I changed my mount for the Neo it had to be re-trained with several hours of driving. Not just several hours, but also uploading all the data from the previous drives. I am not sure how long it takes after you upload a drive to have the new calibration take effect. I just know after a couple of days it would steer better. |
Good point, might need more calibration, try that before changing code |
John, Most of what you describe sounds like a lack of sufficient driving to train the system. How long have you been driving for and uploading your drives back to comma.ai? Are you changing the way you mount the Neo in any way, or does it tend to stay in the same place? The brake error seems to happen to many cars, not just the CR-V. You can find people talking about this in other treads. |
I been leave the mount at one location. Couples hours first day, and couples hours second days. Mainly I only drive it on the weekend. This holiday I will drive more. For the calibration? Does it need to be driving using the neos it self or it need me to drive it for several hours and then upload the data overnight, then drive using the neos again? |
The latter, but calibration doesn't need several hours, only about 30-45 minutes are required using the NEO (openpilot does not have to be engaged) then upload that data to the cloud. |
just version bump
Fix relative velocity issues
* Fix for mock car crash * fix ALCA module * do not use * radar_interface logic improvements * remove radar logging * radar_interface refactoring * Log radar_interface CAN error, Process Comm Errors (commaai#95) * Log radar_interface CAN error * Add support for process comm error logging * Improve Process Comm error logging * Can and CommError throttling * Update radar_interface.py * fixing push per Raf's comments * ALCA and radar_interface work (commaai#96) (commaai#97) * do not use * radar_interface logic improvements * remove radar logging * radar_interface refactoring * Update radar_interface.py * fixing push per Raf's comments * fix process comm issue * switch radard from lane_parser to model * radar/ALCA changes * fix lane width * switched back to not deleting CarParams to avoid radar failure when rebooting EON while driving * cleanup some debug info to be able to restart ALCA research * tweaks on safety_tesla.h for can bus isolation * few more cleanups to safety_tesla.h * fix start signal logic
* fix ALCA module * Update ALCA_module.py * Promote panda fixes from alpha to devel (commaai#98) * Fix for mock car crash * fix ALCA module * do not use * radar_interface logic improvements * remove radar logging * radar_interface refactoring * Log radar_interface CAN error, Process Comm Errors (commaai#95) * Log radar_interface CAN error * Add support for process comm error logging * Improve Process Comm error logging * Can and CommError throttling * Update radar_interface.py * fixing push per Raf's comments * ALCA and radar_interface work (commaai#96) (commaai#97) * do not use * radar_interface logic improvements * remove radar logging * radar_interface refactoring * Update radar_interface.py * fixing push per Raf's comments * fix process comm issue * switch radard from lane_parser to model * radar/ALCA changes * fix lane width * switched back to not deleting CarParams to avoid radar failure when rebooting EON while driving * cleanup some debug info to be able to restart ALCA research * tweaks on safety_tesla.h for can bus isolation * few more cleanups to safety_tesla.h * fix start signal logic * Increase LEXUS_IS safetyParam to 77 (commaai#841) * use list comprehension (commaai#839) * use list comprehension * oops index range fix * simplify encode/decode in dbc (commaai#840) * simplify encode/decode * 2019 Highlander Hybrid Limited Platinum (commaai#843) fingerprint from ogdragonzypher on Discord * Allow to lock safety mode to keep gm/tesla cars supported (commaai#844) * Force subaru to assume the stock camera is connected (commaai#849) * Revert to using the sum of the lane line probabilities instead of the the product * Add core OP support for CRC validation, with extra support for Volkswagen MQB (commaai#836) * Generalized core OP CRC support plus extra bits for Volkswagen MQB. * Update ref to process_replay regression test * Remove unneded use of replace, causing json to fail loading the alert * Add supported car for 2019 Toyota Altis Hybrid (commaai#859) * add supported car for 2019 Toyota Altis Hybird / Corolla hybrid 2020 (US market) * remove unnecessary comprehensions (commaai#863) * Added fingerprint from Sienna XLE AWD (commaai#848) * Added fingerprint from Sienna XLE AWD * Update driver_monitor.py * Update driver_monitor.py * Update driver_monitor.py * fix stupid merge issue * Adds 2019 Lexus ES (non hybrid) (commaai#866) * Adds 2019 Lexus ES (non hybrid) * Updated test route * merge issues * Update README with now supported Subaru Harness * Disable LDW for 4 seconds after blinker transition from on to off (commaai#112) If we want to change lanes with a blinker tap (3 blink mode), then we need to disable LDW for enough time to allow a smooth manual lane change. 4 seconds as it seems the freq is actually around 50Hz, not 100Hz. * Disable HSO for 3 seconds after blinker has been active (commaai#111) Avoid HSO will deactivate and try to take the car back into the lane during a manual lane change with blinker tapped (3 blinks mode) * params learner to only learn @ cons speed Acceleration/deceleration in turns affect yaw as measured by phone and will create potential issues with learner. This code changes the learner to only adjust parameters when speed is constant * Update to match new version of python in eons * python 3 fixes for test client / server * async/await server * Don't log for action message as it's too often, and we throttle it internally. * fix merge issue in thermald * fixes and tweaks; code simplification * Saving P,I,F parameters from pid controller (commaai#116) Added separate save/load functions, try catch - and saving the right constants to the params file. * Feature/tinklad throttling + linting (commaai#118) * Throttle tinlkad's attemptToSendPendingMessages * Remove get_git_remote from registration. It's defined in version already. * tinklad linting * tesla linting * Prevent multiple readings of the pid params file (commaai#119) ..only load the pid values when we initiate the LoC * missing V_PID_FILE constant (commaai#121) * show cars in IC for non-radar users (commaai#120) * bug fixes * Fix issue where user info was being dropped on no connectivity (commaai#122) * move pisParams, fix GPS logging * Bugfix tinklad throttling (commaai#124) * ALCA4 (still in dev) * ALCA4 tuning * ALCA4 alpha release * ALCA4 tweak for turns * ACC fix; LDW mite during ALCA * ALCA polishing * fix enter_canloader.py for python 3 * should_ldw changes moved the should_ldw code closer together and added status messages for when LDW is active and inactive * thermald and ALCA * ALCA sinplified logic
* add auto-df * move dynamic follow into its own module * updates * use prettier classes instead of dicts * move car_data to dynamic_follow * use more classes! * remove * Refactor the df_alert_manager * fix * debugging and fix * fix * fix recursion * fix recursion * fix * fix * fixes * debugging * fix * fix * test * test * fix * fix * Verify it's working * benchmark * benchmark * benchmark * only predict if lead and at 5Hz * wait for initial auto alert to finish before showing predictions, no sound when model predicts a profile * Fix * Fix * Fix * Fix * Fix * This should fix auto alert disappearing quickly * rename
Working on this with @johnnwvs Fingerprint of the car here:
The text was updated successfully, but these errors were encountered: