bug with when there are no pages

comfy · Dec 9, 2019 · b85e105 · b85e105
1 parent e8d02b2
commit b85e105
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/app/models/comfy/cms/page.rb b/app/models/comfy/cms/page.rb
@@ -51,6 +51,7 @@ def self.options_for_select(site:, current_page: nil, exclude_self: false)
     options = []
 
     options_for_page = ->(page, depth = 0) do
+      return if page.nil?
       return if exclude_self && page == current_page
 
       options << ["#{'. . ' * depth}#{page.label}", page.id]

diff --git a/test/models/page_test.rb b/test/models/page_test.rb
@@ -393,6 +393,9 @@ def test_options_for_select
       exclude_self: true
     ).map(&:first)
     assert_equal expected, actual
+
+    Comfy::Cms::Page.delete_all
+    assert_equal [], Comfy::Cms::Page.options_for_select(site: @site).map(&:first)
   end
 
   def test_fragments_attributes