Fill time field in ExecCommitBlock
#746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mempool + make it debug"
state/execution_test.go
Outdated
| @@ -206,10 +206,11 @@ func TestFinalizeBlockValidators(t *testing.T) { | |||
| desc string | |||
| lastCommitSigs []types.ExtendedCommitSig | |||
| expectedAbsentValidators []int | |||
| shouldHaveTs bool | |||
There was a problem hiding this comment.
The linter's complaining about this field name - is the "Ts" meant to represent "timestamp"?
There was a problem hiding this comment.
Yes. What do you suggest?
E.g., shall I expand Ts to Timestamp ?
There was a problem hiding this comment.
Actually, simpler, I'll rename it to shouldHaveTime
There was a problem hiding this comment.
The linter was recommending shouldHaveTS, but any of those should do.
lasarojc
approved these changes
Apr 24, 2023
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Rephrase log when committed TX not in local mempool + make it debug * Add failing UT * Fill time in ExecCommitBlock * Fix UT logic * Revert unrelated commit "Rephrase log when committed TX not in local mempool + make it debug" * Fix lint (cherry picked from commit b8187b0)
sergio-mena
added a commit
that referenced
this pull request
Apr 25, 2023
* Rephrase log when committed TX not in local mempool + make it debug * Add failing UT * Fill time in ExecCommitBlock * Fix UT logic * Revert unrelated commit "Rephrase log when committed TX not in local mempool + make it debug" * Fix lint (cherry picked from commit b8187b0) Co-authored-by: Sergio Mena <sergio@informal.systems>
thanethomson
pushed a commit
that referenced
this pull request
May 6, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #739
Similar to #687,
ExecCommitBlockis not filling thetimefield. Further, there was no UT catching this.This PR add logic to an existing test case to check for that field. The test case is initially failing. When added the production fix (and fixing the test case logic), the test case passes.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments