Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto: completely remove cometbft.crypto.v1.PublicKey #2878

Open
melekes opened this issue Apr 23, 2024 · 2 comments · Fixed by #2890
Open

proto: completely remove cometbft.crypto.v1.PublicKey #2878

melekes opened this issue Apr 23, 2024 · 2 comments · Fixed by #2890
Labels
breaking A breaking change crypto Cryptography-related protobuf Protocol buffers-related
Milestone
2024-Q4

Comments

@melekes
Copy link
Contributor

melekes commented Apr 23, 2024 •
edited
Loading

Currently we're still using it in Validator and remote signer, but we need to replace it with Type and Bytes too if we want to support modular crypto.

Refs #2843 (comment)
@melekes melekes added enhancement New feature or request crypto Cryptography-related needs-triage This issue/PR has not yet been triaged by the team. labels Apr 23, 2024
@melekes melekes added this to CometBFT Apr 23, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Apr 23, 2024
@melekes melekes mentioned this issue Apr 23, 2024
Merged
4 tasks
melekes added a commit that referenced this issue Apr 25, 2024
@melekes
feat(proto)!: replace pub_key with pub_key_type
fc54695 
and `pub_key_bytes` in `privval.PubKeyResponse`, `types.Validator` and
`types.SimpleValidator`.

Closes #2878
@melekes melekes mentioned this issue Apr 25, 2024
Merged
4 tasks
melekes added a commit that referenced this issue Apr 25, 2024
@melekes
feat(proto)!: replace pub_key with pub_key_type
bb31051 
and `pub_key_bytes` in `privval.PubKeyResponse`, `types.Validator` and
`types.SimpleValidator`.

Closes #2878
@melekes melekes added protobuf Protocol buffers-related and removed enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. labels Apr 25, 2024
@melekes melekes moved this from Todo to Ready for Review in CometBFT Apr 25, 2024
@melekes melekes added this to the 2024-Q2 milestone Apr 25, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 29, 2024
@melekes @sergio-mena
feat(proto)!: replace pub_key with pub_key_type (#2890)
d342b3a 
and `pub_key_bytes` in `privval.PubKeyResponse`, `types.Validator` and
`types.SimpleValidator`.

Closes #2878
Follow-up to #2843
<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in CometBFT Apr 29, 2024
mergify bot pushed a commit that referenced this issue Apr 29, 2024
@melekes @mergify
feat(proto)!: replace pub_key with pub_key_type (#2890)
2381160 
and `pub_key_bytes` in `privval.PubKeyResponse`, `types.Validator` and
`types.SimpleValidator`.

Closes #2878
Follow-up to #2843
<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
(cherry picked from commit d342b3a)
@mergify mergify bot mentioned this issue Apr 29, 2024
Merged
4 tasks
melekes added a commit that referenced this issue Apr 29, 2024
@mergify @melekes
feat(proto)!: replace pub_key with pub_key_type (backport #2890) (#…
4d7da6b 
…2922)

and `pub_key_bytes` in `privval.PubKeyResponse`, `types.Validator` and
`types.SimpleValidator`.

Closes #2878
Follow-up to #2843


---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request #2890 done by
[Mergify](https://mergify.com).

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
@melekes melekes reopened this May 17, 2024
@melekes
Copy link
Contributor Author

melekes commented May 17, 2024

@melekes melekes added the breaking A breaking change label May 17, 2024
@melekes melekes removed this from the 2024-Q2 milestone May 17, 2024
@melekes melekes moved this from Done to Todo in CometBFT May 17, 2024
@melekes melekes added this to the 2024-Q4 milestone May 17, 2024
@jmalicevic jmalicevic moved this from Todo to Blocked in CometBFT Sep 23, 2024
@jmalicevic
Copy link
Contributor

Blocked on #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking A breaking change crypto Cryptography-related protobuf Protocol buffers-related
Projects
CometBFT
Status: Blocked
Milestone
2024-Q4
Development

Successfully merging a pull request may close this issue.

feat(proto)!: replace pub_key with pub_key_type cometbft/cometbft
2 participants
@melekes @jmalicevic