feat(404 - rsr-1004): Add constraints to update compas flow bindings #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GuillaumeJAFFRE
commented
Jun 28, 2024
- modification of ExtRefEditorService and add a test
- modification of ExtRefEditor interface to return List with updateIedNameBasedOnLnode()
gleizesDor
reviewed
Jul 2, 2024
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/ExtRefEditorService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/ExtRefEditorService.java
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/ExtRefEditorService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/ExtRefEditorServiceTest.java
Outdated
Show resolved
Hide resolved
massifben
reviewed
Jul 3, 2024
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/ExtRefEditorServiceTest.java
Outdated
Show resolved
Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/ExtRefEditorServiceTest.java
Outdated
Show resolved
Hide resolved
gleizesDor
reviewed
Jul 5, 2024
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/ExtRefEditorService.java
Outdated
Show resolved
Hide resolved
4d3455b to
4734324
Compare
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/ExtRefEditorService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/ExtRefEditorService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/ExtRefEditorServiceTest.java
Show resolved
Hide resolved
samirromdhani
approved these changes
Jul 10, 2024
- modification of ExtRefEditorService and add a test - modification of ExtRefEditor interface to return List<SclReportItem> with updateIedNameBasedOnLnode() Signed-off-by: JAFFRE Guillaume <guillaume.jaffre@rte-france.com>
4734324 to
25e13a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.