feat(211): Evolution on Services types verification for ControlBlock … #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gleizesDor
reviewed
Dec 23, 2022
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ied/IEDAdapterTest.java
Show resolved
Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ied/IEDAdapterTest.java
Outdated
Show resolved
Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ied/IEDAdapterTest.java
Outdated
Show resolved
Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ied/IEDAdapterTest.java
Outdated
Show resolved
Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ied/IEDAdapterTest.java
Outdated
Show resolved
Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ied/IEDAdapterTest.java
Outdated
Show resolved
Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ied/IEDAdapterTest.java
Outdated
Show resolved
Hide resolved
massifben
reviewed
Dec 27, 2022
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/ied/IEDAdapter.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/ied/IEDAdapter.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/ied/IEDAdapter.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/ied/IEDAdapter.java
Outdated
Show resolved
Hide resolved
|
I don't think it is a good idea to use preview features of Java. |
AliouDIAITE
reviewed
Dec 29, 2022
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ied/LDeviceAdapterTest.java
Show resolved
Hide resolved
cebee42 to
c603018
Compare
AliouDIAITE
approved these changes
Dec 29, 2022
Signed-off-by: massifben <105049157+massifben@users.noreply.github.com> Co-authored-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com> Co-authored-by: massifben <105049157+massifben@users.noreply.github.com>
c603018 to
be66005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evolution on Service types verification for ControlBlock and DataSet creation
Enable preview for java 17 features
Add enable-preview in properties for Java 17 switch (needed for tests)
Upgrade Cache Action to v3