Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[68][164] Activation used LDevice and Deactivation unused LDevice #163

Merged
merged 1 commit into from
Oct 3, 2022
Merged

[68][164] Activation used LDevice and Deactivation unused LDevice #163

merged 1 commit into from
Oct 3, 2022

Conversation

samirromdhani
Copy link
Contributor

Signed-off-by: Aliou DIAITE aliou.diaite@rte-france.com
Signed-off-by: Samir Romdhani samir.romdhani@rte-france.com

@samirromdhani samirromdhani linked an issue Sep 22, 2022 that may be closed by this pull request
RSR-396 : Activate used LDevice and Deactivate unused LDevice according to Function/LNode in /Substation - Part 4 of 4 #68
Closed
@samirromdhani samirromdhani changed the title [68] WIP [68] Activation used LDevice and Deactivation unused LDevice Sep 22, 2022
@samirromdhani samirromdhani force-pushed the feat/68-activate-used-ldevice-and-deactivate-unused-ldevice branch 7 times, most recently from 2ebc36e to e833ebe Compare September 23, 2022 16:00
@samirromdhani samirromdhani linked an issue Sep 23, 2022 that may be closed by this pull request
[RSR-561] - COMPAS - Activate used LDevice and Deactivate unused LDevice according to Function/LNode in /Substation - Part 4/4 Addendum RSR-396 #68 #164
Closed
@samirromdhani samirromdhani changed the title [68] Activation used LDevice and Deactivation unused LDevice [68][164] Activation used LDevice and Deactivation unused LDevice Sep 23, 2022
@samirromdhani samirromdhani force-pushed the feat/68-activate-used-ldevice-and-deactivate-unused-ldevice branch 13 times, most recently from 4e6e2cb to 090141f Compare September 26, 2022 13:36
@samirromdhani samirromdhani force-pushed the feat/68-activate-used-ldevice-and-deactivate-unused-ldevice branch from 090141f to 36f8d9d Compare September 26, 2022 14:30
massifben
massifben reviewed Sep 29, 2022
View reviewed changes
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/dto/ResumedDataTemplate.java Outdated Show resolved Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/dto/SclReport.java Outdated Show resolved Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/dtt/DAAdapter.java Show resolved Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/dtt/DOAdapter.java Outdated Show resolved Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/dtt/LNodeTypeAdapter.java Outdated Show resolved Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ied/LN0AdapterTest.java Show resolved Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ied/LN0AdapterTest.java Show resolved Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ied/LN0AdapterTest.java Show resolved Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ied/LN0AdapterTest.java Show resolved Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/SclServiceTest.java Outdated Show resolved Hide resolved
@AliouDIAITE AliouDIAITE force-pushed the feat/68-activate-used-ldevice-and-deactivate-unused-ldevice branch from bea0422 to 71ebbd5 Compare September 30, 2022 09:07
@samirromdhani samirromdhani force-pushed the feat/68-activate-used-ldevice-and-deactivate-unused-ldevice branch from 71ebbd5 to 3462385 Compare October 3, 2022 08:25
@samirromdhani
[68][164] Activation used LDevice and Deactivation unused LDevice
0e183e8 
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>

apply correction after code review

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>

add parameterized test

Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
@samirromdhani samirromdhani force-pushed the feat/68-activate-used-ldevice-and-deactivate-unused-ldevice branch from 5f6d6e4 to 0e183e8 Compare October 3, 2022 14:39
@AliouDIAITE AliouDIAITE merged commit 0788c4c into develop Oct 3, 2022
@AliouDIAITE AliouDIAITE deleted the feat/68-activate-used-ldevice-and-deactivate-unused-ldevice branch October 3, 2022 14:45
AliouDIAITE pushed a commit that referenced this pull request Oct 3, 2022
@samirromdhani @AliouDIAITE
[68][164] Activation used LDevice and Deactivation unused LDevice (#163)
4074d64 
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
@massifben massifben mentioned this pull request Oct 21, 2022
Merged
AliouDIAITE pushed a commit that referenced this pull request Oct 24, 2022
@samirromdhani @AliouDIAITE
[68][164] Activation used LDevice and Deactivation unused LDevice (#163)
8d569c6 
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
AliouDIAITE pushed a commit that referenced this pull request Oct 24, 2022
@samirromdhani @AliouDIAITE
[68][164] Activation used LDevice and Deactivation unused LDevice (#163)
1442308 
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
SaintierFr pushed a commit that referenced this pull request Oct 26, 2022
@samirromdhani @SaintierFr
[68][164] Activation used LDevice and Deactivation unused LDevice (#163)
91c0751 
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
Signed-off-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@massifben massifben massifben approved these changes

@AliouDIAITE AliouDIAITE Awaiting requested review from AliouDIAITE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.1.1 of CoMPAS SCT
3 participants
@samirromdhani @AliouDIAITE @massifben