Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateDAI Val does not produce subelements (SDI) as expected #241

Closed
SaintierFr opened this issue Feb 16, 2023 · 0 comments · Fixed by #250
Closed

UpdateDAI Val does not produce subelements (SDI) as expected #241

SaintierFr opened this issue Feb 16, 2023 · 0 comments · Fixed by #250
Labels
bug Something isn't working

Comments

@SaintierFr
Copy link
Member

SaintierFr commented Feb 16, 2023

Subject of the issue

Issue when creating DO and DA objects with the SDO and BDA subelements

Your environment

  • Version of CoMPAS-SCT 0.2.3

Steps to reproduce

The object ResumedDataTemplate has doTypeName = "doName.sdoName1.sdoName2" and daTypeName = "daName.bdaName1.bdaName2.bdaName3"
Call updateDAI method
(See LNAdapterTest class)

In this case daName is a Struct type, it will be instantiated as TSDI object and the final instantiated object TDAI should be bdaName3.

Expected behaviour

The expected output:

  <DOI name="doName">
      <SDI name="sdoName1">
          <SDI name="sdoName2">
              <SDI name="daName">
                  <SDI name="bdaName1">
                      <SDI name="bdaName2">
                          <DAI name="bdaName3" valImport="true">
                              <Val>newValue</Val>
                          </DAI>
                      </SDI>
                  </SDI>
             </SDI>
        </SDI>
  </DOI>

Actual behaviour
Output:

  <DOI name="doName">
      <SDI name="sdoName1">
          <SDI name="sdoName2">
              <SDI name="daName"/>
              <SDI name="daName"/>
              <SDI name="daName"/>
              <DAI name="daName" valImport="true">
                  <Val>newValue</Val>
              </DAI>
          </SDI>
      </SDI>
  </DOI>
@SaintierFr SaintierFr added the bug Something isn't working label Feb 16, 2023
SaintierFr added a commit that referenced this issue Feb 16, 2023
Signed-off-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>
SaintierFr added a commit that referenced this issue Feb 16, 2023
* fix(#239): Exclude DOI Mod-stVal in DAI updatability check
* fix(#239): Comment unit test in error while bug #241 is not fixed

Signed-off-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>
SaintierFr added a commit that referenced this issue Feb 16, 2023
* feat(216): check that Datasets, FCDAs, ControlBlocks (GOOSE, REPORT and SMV) satisfy limits fixed by config

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* build(deps): bump alex-page/github-project-automation-plus

Bumps [alex-page/github-project-automation-plus](https://github.com/alex-page/github-project-automation-plus) from 0.8.2 to 0.8.3.
- [Release notes](https://github.com/alex-page/github-project-automation-plus/releases)
- [Commits](alex-page/github-project-automation-plus@v0.8.2...v0.8.3)

---
updated-dependencies:
- dependency-name: alex-page/github-project-automation-plus
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* feat(216): check that Datasets, FCDAs, ControlBlocks (GOOSE, REPORT and SMV) satisfy limits fixed by config

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>

* chore(217): use built-in Maven cache mechanism of setup-java GitHub
Action

fixes #217

Signed-off-by: Aurélien Pupier <apupier@redhat.com>

* Fix typos in docs

Signed-off-by: Aurélien Pupier <apupier@redhat.com>

* feat/javadoc: automate Javadoc deployment via gh-pages (#229)

fixes maven plugin related to jdk17

Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>

feat/javadoc: automate Javadoc remove PR creation and push directly gh-pages branch

* feat(231): Automatic binding: Edit InRef from ExtRef

Signed-off-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>

* fix(#235): Error occurs when importing STD file during SCD automated creation

Signed-off-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>

* fix(#239): Exclude DOI Mod-stVal in DAI updatability check (#240)

* fix(#239): Exclude DOI Mod-stVal in DAI updatability check
* fix(#239): Comment unit test in error while bug #241 is not fixed

Signed-off-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>

---------

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Signed-off-by: SaintierFr  <99645240+SaintierFr@users.noreply.github.com>
Signed-off-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>
Co-authored-by: Aliou DIAITE <aliou.diaite@rte-france.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pascal Wilbrink <pascal.wilbrink@gmail.com>
Co-authored-by: Aurélien Pupier <apupier@redhat.com>
Co-authored-by: Samir Romdhani <samir.romdhani@rte-france.com>
massifben added a commit that referenced this issue Mar 2, 2023
Signed-off-by: massifben <105049157+massifben@users.noreply.github.com>
@massifben massifben linked a pull request Mar 2, 2023 that will close this issue
massifben added a commit that referenced this issue Mar 15, 2023
Signed-off-by: massifben <105049157+massifben@users.noreply.github.com>
massifben added a commit that referenced this issue Mar 15, 2023
Signed-off-by: massifben <105049157+massifben@users.noreply.github.com>
massifben added a commit that referenced this issue Mar 15, 2023
Signed-off-by: massifben <105049157+massifben@users.noreply.github.com>
massifben added a commit that referenced this issue Mar 15, 2023
Signed-off-by: massifben <105049157+massifben@users.noreply.github.com>
massifben added a commit that referenced this issue Mar 16, 2023
Signed-off-by: massifben <105049157+massifben@users.noreply.github.com>
massifben added a commit that referenced this issue Mar 16, 2023
…ce-subelements-sdi-as-expected

fix(#241): updateDai does not create DOI SDI DAI as expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant