-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop
into main
#225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps ubi8/ubi-minimal from 8.5 to 8.6. --- updated-dependencies: - dependency-name: ubi8/ubi-minimal dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps `quarkus.platform.version` from 2.8.3.Final to 2.9.0.Final. Updates `quarkus-universe-bom` from 2.8.3.Final to 2.9.0.Final - [Release notes](https://github.com/quarkusio/quarkus-platform/releases) - [Commits](quarkusio/quarkus-platform@2.8.3.Final...2.9.0.Final) Updates `quarkus-maven-plugin` from 2.8.3.Final to 2.9.0.Final --- updated-dependencies: - dependency-name: io.quarkus:quarkus-universe-bom dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.quarkus:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Flurb <private@tjalma.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps `quarkus.platform.version` from 2.9.0.Final to 2.9.1.Final. Updates `quarkus-universe-bom` from 2.9.0.Final to 2.9.1.Final - [Release notes](https://github.com/quarkusio/quarkus-platform/releases) - [Commits](quarkusio/quarkus-platform@2.9.0.Final...2.9.1.Final) Updates `quarkus-maven-plugin` from 2.9.0.Final to 2.9.1.Final --- updated-dependencies: - dependency-name: io.quarkus:quarkus-universe-bom dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkus:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps `quarkus.platform.version` from 2.9.1.Final to 2.9.2.Final. Updates `quarkus-universe-bom` from 2.9.1.Final to 2.9.2.Final - [Release notes](https://github.com/quarkusio/quarkus-platform/releases) - [Commits](quarkusio/quarkus-platform@2.9.1.Final...2.9.2.Final) Updates `quarkus-maven-plugin` from 2.9.1.Final to 2.9.2.Final --- updated-dependencies: - dependency-name: io.quarkus:quarkus-universe-bom dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkus:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps `surefire-plugin.version` from 3.0.0-M6 to 3.0.0-M7. Updates `maven-surefire-plugin` from 3.0.0-M6 to 3.0.0-M7 - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.0.0-M6...surefire-3.0.0-M7) Updates `maven-failsafe-plugin` from 3.0.0-M6 to 3.0.0-M7 - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.0.0-M6...surefire-3.0.0-M7) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven.plugins:maven-failsafe-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v3.3.0...v3.4.0) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [powsybl-single-line-diagram-core](https://github.com/powsybl/powsybl-single-line-diagram) from 2.10.0 to 2.11.0. - [Release notes](https://github.com/powsybl/powsybl-single-line-diagram/releases) - [Commits](powsybl/powsybl-diagram@v2.10.0...v2.11.0) --- updated-dependencies: - dependency-name: com.powsybl:powsybl-single-line-diagram-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps `quarkus.platform.version` from 2.9.2.Final to 2.10.0.Final. Updates `quarkus-universe-bom` from 2.9.2.Final to 2.10.0.Final - [Release notes](https://github.com/quarkusio/quarkus-platform/releases) - [Commits](quarkusio/quarkus-platform@2.9.2.Final...2.10.0.Final) Updates `quarkus-maven-plugin` from 2.9.2.Final to 2.10.0.Final --- updated-dependencies: - dependency-name: io.quarkus:quarkus-universe-bom dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.quarkus:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps `compas.core.version` from 0.9.0 to 0.9.1. Updates `commons` from 0.9.0 to 0.9.1 Updates `jaxrs-commons` from 0.9.0 to 0.9.1 --- updated-dependencies: - dependency-name: org.lfenergy.compas.core:commons dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.lfenergy.compas.core:jaxrs-commons dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [jandex-maven-plugin](https://github.com/wildfly/jandex-maven-plugin) from 1.2.2 to 1.2.3. - [Release notes](https://github.com/wildfly/jandex-maven-plugin/releases) - [Commits](wildfly/jandex-maven-plugin@1.2.2...1.2.3) --- updated-dependencies: - dependency-name: org.jboss.jandex:jandex-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps `quarkus.platform.version` from 2.10.0.Final to 2.10.1.Final. Updates `quarkus-universe-bom` from 2.10.0.Final to 2.10.1.Final - [Release notes](https://github.com/quarkusio/quarkus-platform/releases) - [Commits](quarkusio/quarkus-platform@2.10.0.Final...2.10.1.Final) Updates `quarkus-maven-plugin` from 2.10.0.Final to 2.10.1.Final --- updated-dependencies: - dependency-name: io.quarkus:quarkus-universe-bom dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkus:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps `quarkus.platform.version` from 2.10.1.Final to 2.10.2.Final. Updates `quarkus-universe-bom` from 2.10.1.Final to 2.10.2.Final - [Release notes](https://github.com/quarkusio/quarkus-platform/releases) - [Commits](quarkusio/quarkus-platform@2.10.1.Final...2.10.2.Final) Updates `quarkus-maven-plugin` from 2.10.1.Final to 2.10.2.Final --- updated-dependencies: - dependency-name: io.quarkus:quarkus-universe-bom dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkus:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.4.0 to 3.4.1. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v3.4.0...v3.4.1) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps `quarkus.platform.version` from 2.10.2.Final to 2.10.3.Final. Updates `quarkus-universe-bom` from 2.10.2.Final to 2.10.3.Final - [Release notes](https://github.com/quarkusio/quarkus-platform/releases) - [Commits](quarkusio/quarkus-platform@2.10.2.Final...2.10.3.Final) Updates `quarkus-maven-plugin` from 2.10.2.Final to 2.10.3.Final --- updated-dependencies: - dependency-name: io.quarkus:quarkus-universe-bom dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.quarkus:quarkus-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.9 to 0.8.10. - [Release notes](https://github.com/jacoco/jacoco/releases) - [Commits](jacoco/jacoco@v0.8.9...v0.8.10) --- updated-dependencies: - dependency-name: org.jacoco:jacoco-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [maven-source-plugin](https://github.com/apache/maven-source-plugin) from 3.2.1 to 3.3.0. - [Commits](apache/maven-source-plugin@maven-source-plugin-3.2.1...maven-source-plugin-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-source-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
#204) Bumps ubi8/ubi-minimal from 8.7-1107 to 8.8-860. --- updated-dependencies: - dependency-name: ubi8/ubi-minimal dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Steffen van den Driest <35229971+Stef3st@users.noreply.github.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
The main change is migrating from JavaEE to JakartaEE. - update Quarkus bom from io.quarkus:quarkus-universe-bom to io.quarkus.platform:quarkus-bom as it was deprecated since Quarkus 2.1 https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.1#quarkus-universe-bom-is-deprecated (and it is required to use the Quarkus migration tool) - launched quarkus `quarkus update --stream=3.0` as mentioned in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0#automatic-update-tool which dealt with a fair part of the migration. Then it remained few little tasks. - Updated quarkus.index-dependency for jaxb from org.jboss.spec.javax.xml.bind:jboss-jaxb-api_2.3_spec to `jakarta.xml.bind:jakarta.xml.bind-api` fix #202 Signed-off-by: Aurélien Pupier <apupier@redhat.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [microprofile-openapi-api](https://github.com/eclipse/microprofile-open-api) from 3.1 to 3.1.1. - [Release notes](https://github.com/eclipse/microprofile-open-api/releases) - [Commits](microprofile/microprofile-open-api@3.1...3.1.1) --- updated-dependencies: - dependency-name: org.eclipse.microprofile.openapi:microprofile-openapi-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [fsfe/reuse-action](https://github.com/fsfe/reuse-action) from 1 to 2. - [Release notes](https://github.com/fsfe/reuse-action/releases) - [Commits](fsfe/reuse-action@v1...v2) --- updated-dependencies: - dependency-name: fsfe/reuse-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@gmail.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2 to 3. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2...v3) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps ubi8/ubi-minimal from 8.8-860 to 8.8-1072. --- updated-dependencies: - dependency-name: ubi8/ubi-minimal dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps `surefire-plugin.version` from 3.0.0 to 3.1.2. Updates `maven-surefire-plugin` from 3.0.0 to 3.1.2 - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.0.0...surefire-3.1.2) Updates `maven-failsafe-plugin` from 3.0.0 to 3.1.2 - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.0.0...surefire-3.1.2) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.maven.plugins:maven-failsafe-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [docker/login-action](https://github.com/docker/login-action) from 2 to 3. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v2...v3) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.5.0 to 3.6.0. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.5.0...maven-javadoc-plugin-3.6.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [fsfe/reuse-action](https://github.com/fsfe/reuse-action) from 1 to 2. - [Release notes](https://github.com/fsfe/reuse-action/releases) - [Commits](fsfe/reuse-action@v1...v2) --- updated-dependencies: - dependency-name: fsfe/reuse-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@gmail.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
This reverts commit 2869a40. Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Dennis Labordus <dennis.labordus@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Bumps [fsfe/reuse-action](https://github.com/fsfe/reuse-action) from 1 to 2. - [Release notes](https://github.com/fsfe/reuse-action/releases) - [Commits](fsfe/reuse-action@v1...v2) --- updated-dependencies: - dependency-name: fsfe/reuse-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@gmail.com> Signed-off-by: Juan Muñoz <juan.munoz@alliander.com> Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
383f3c3
to
8b11298
Compare
Signed-off-by: Pascal Wilbrink <pascal.wilbrink@alliander.com>
Fixed merge conflicts
# Conflicts: # .github/workflows/build-project.yml # .github/workflows/release-project.yml # .github/workflows/sonarcloud-analysis.yml # app/src/main/docker/Dockerfile.jvm # app/src/main/docker/Dockerfile.native # pom.xml # service/src/main/java/org/lfenergy/compas/scl/auto/alignment/service/SclAutoAlignmentService.java
Kudos, SonarCloud Quality Gate passed!
|
pascalwilbrink
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre release PR