Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable dublicate tests compas openscd #245

Merged
merged 4 commits into from
May 16, 2023
Merged

fix: disable dublicate tests compas openscd #245

merged 4 commits into from
May 16, 2023

Conversation

Stef3st
Copy link

@Stef3st Stef3st commented May 10, 2023

closes #244

@Stef3st Stef3st self-assigned this May 10, 2023
@Stef3st Stef3st linked an issue May 10, 2023 that may be closed by this pull request
Disable dublicate tests CoMPAS-OpenSCD #244
Closed
@Stef3st
Copy link
Author

Stef3st commented May 10, 2023 •
edited
Loading

@pascalwilbrink I see that you've put sitipe in the "editors" folder. My suggestion is from now on to put compas editors in the compas-editors folder. That makes it easier to skip the open-scd tests. Do you agree?

Done in commit: d5d2181

@Stef3st Stef3st requested a review from Sander3003 May 10, 2023 08:37
@Sander3003
Copy link
Member

Agree

@Stef3st Stef3st requested a review from juancho0202 May 15, 2023 08:00
@Sander3003
Copy link
Member

I don't feel comfortable to review this :)

@juancho0202 juancho0202 merged commit 69b8636 into main May 16, 2023
@juancho0202 juancho0202 deleted the 244-disable-dublicate-tests-compas-openscd branch May 16, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancho0202 juancho0202 juancho0202 approved these changes

@pascalwilbrink pascalwilbrink Awaiting requested review from pascalwilbrink

@Sander3003 Sander3003 Awaiting requested review from Sander3003

Assignees

@Stef3st Stef3st

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable dublicate tests CoMPAS-OpenSCD
3 participants
@Stef3st @Sander3003 @juancho0202