Refactor of Websocket wrapper to use promise. #207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@juancho0202 as already told a nicer version for using websocket.
The websocket function now returns a Promise like most rest calls are also doing after some response handling.
If something goes wrong a reject is done with the reason body as used in other places with rest calls.
This way the handling if websocket or rest should be used could be hidden in the service layer.
Calling code doesn't know anymore.
Remark: I created a local container image and used the Docker Compose file and robot test script to validate the change.