Turn back on Scala 3 tests, enable big-case-class tests #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on tests to verify #386
Scala 3 tests were accidentally disabled in #553, this re-enables them
The big-case-class tests do work, with the caveat you need to set
-Xmax-inlinesto be greater than the width of your case class, and the compilation is notably slower on 3.3.1 than in Scala 213.11. However, the performance seems to be better in 3.4.0, and-Xmax-inlinesis no longer necessary.For now, I just add
-Xmax-inlinesand accept the compilation slowness, so as to not break anyone using Scala 3.3.1. Eventually, as people upgrade to 3.4.0, the problem can be expected to go away