Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow even more dynamic instrumentation of pwd via os.dynamicPwdFunction #299

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Sep 7, 2024

Follow up to #298, which it turns out was not flexible enough to do what we need in Mill. Mill uses references to the pwd to create the .dest folder lazily, thus we cannot just assign a value to the os.pwd but actually need to assign a lambda that can be replaced to implement the lazy evaluation

I pulled the trigger too quickly on releasing 0.10.6 with os.dynamicPwd, so this one has to be named differently. I chose os.dynamicPwdFunction and will make sure to test it with an unstable release before releasing a stable tag

@lihaoyi lihaoyi merged commit 5561ad6 into main Sep 7, 2024
18 checks passed
@lihaoyi lihaoyi deleted the dynamic-pwd-function branch September 7, 2024 11:14
@lihaoyi lihaoyi modified the milestone: 0.10.6 Sep 7, 2024
@lefou lefou added this to the 0.10.7 milestone Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants