Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dist/package.mill #4339

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Clean up dist/package.mill #4339

merged 8 commits into from
Jan 16, 2025

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jan 16, 2025

  • Renames test-mill-dev -> test-dist-run, test-mill-release -> test-install-local
  • Rename InstallModule#jar to InstallModule#executableRaw
  • Move def prependShellScript logic into def launcher; previously it was only used there, although it normally would be used by assembly, which was very confusing
  • Make def executableRaw directly use assembly with proper forkArgs/forkShellArgs/forkCmdArgs configuration
  • Remove def launcherScript and just use Jvm.launcherUniversalScript directly

@lihaoyi lihaoyi marked this pull request as ready for review January 16, 2025 05:44
@lihaoyi lihaoyi merged commit b16c589 into com-lihaoyi:main Jan 16, 2025
28 checks passed
@lefou lefou added this to the 0.12.6 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants