Break out AssemblyModule from JavaModule, move launcher into RunModule
#4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssemblyModule from JavaModuleAssemblyModule from JavaModule, move launcher into RunModule
|
not sure why these changes are causing |
|
OOMing appears to be a transient, seems like it passed now |
lefou
reviewed
Jan 13, 2025
| import scala.annotation.nowarn | ||
|
|
||
| /** | ||
| * Core configuration required to compile a single Java compilation target |
vaslabs
pushed a commit
to vaslabs-ltd/mill
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3141
We cannot call
super.assemblydue to some weird bincompat stuff, so instead we make aprivate[mill] AssemblyModule#assembly0which contains the real implementation that bothAssemblyModule#assemblyandJavaModule#assemblycan call. Same for movinglauncherI left the "input" tasks to the assembly process abstract, and the "output" tasks concrete. So when
AssemblyModuleis mixed intoJavaModuleit picks up the right tasks to use automatically, but it can also be used outside ofJavaModuleif you provide the variousforkArgs/manifest/localClasspath/etc. yourself