Use -native Mill binary in Mill's own build
#4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-native Mill binary in Mill-native Mill binary in Mill's own build
3052f73 to
81d728b
Compare
|
disabling the failing scalapb test on windows for now; it appears to be a test infra issue caused by adding |
Merged
lihaoyi
added a commit
that referenced
this pull request
Jan 16, 2025
Just some cleanup, removes the no longer necessary `setup-java` step and consolidates on `Jvm.launcherUniversalScript`. The unstable version strings look ugly due to #4294 modifying the `.mill-jvm-version` file to change the version, resulting in a `-DIRTY` suffix. Will fix that separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed some fixes in the bootstrap scripts to prevent the enclosing environment from leaking through. We can then remove the
setup-javastep from all of our workflows, since the Mill native executable will bootstrap the JVM as necessaryWe can now run most of github actions jobs without installing Java beforehand, except for the
pre-buildstep whereselective.preparestep which runs onmainand thus does not have these changes. Once this PR is merged, we can removesetup-javafrompre-buildas well