Honor the NO_COLOR env variable #4246
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandtritsch
approved these changes
Jan 4, 2025
|
BTW ... are you also going to update the NO_COLOR website or do you want me to do that? - https://github.com/jcs/no_color |
lefou
requested changes
Jan 4, 2025
When the NO_COLOR env variable is set, then avoid coloring the terminal. --color argument does overrides the env variable Inspired by https://no-color.org and asked in discussion: com-lihaoyi#4170
ee588b5 to
d6295cb
Compare
lolgab
reviewed
Jan 4, 2025
Co-authored-by: Lorenzo Gabriele <lorenzolespaul@gmail.com>
@gamlerhart Sorry for being ambiguous. I meant to add Mill to the no-color.org site. I think the link in the |
This reverts commit 8c8955b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the NO_COLOR env variable is set,
then avoid coloring the terminal.
--color argument does overrides the env variable
Inspired by https://no-color.org
and asked in discussion: #4170