Remove unnecessary .Sources
#4120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of these can just be normal
Tasks, since they simply rely on upstreamTask.Sourcesbut do not add any source paths themselves. And since 0.11.x they're all the same type anyway so changing back and forth doesn't break compatibilityThis speeds up
selective.prepareon the com-lihaoyi/mill codebase considerably, since we need to evaluate all sources (and their transitive upstream tasks) up-front to decide what sources changed and determine the downstream tasks to run. Before this PR this ended up compiling a bunch of Scala code, after this PR it no longer does so