Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Migrating to Mill doc page #4040

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Nov 28, 2024

This is a manual playbook for running such a migration, that will likely be useful even in the presence of semi-automated scaffolding generators

Resolves #4036

@lihaoyi lihaoyi requested review from lefou and lolgab November 28, 2024 03:28
@lihaoyi lihaoyi marked this pull request as ready for review November 28, 2024 03:28
@lihaoyi lihaoyi requested a review from jodersky November 28, 2024 03:44
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I spotted some nits and added suggestions.

lihaoyi and others added 3 commits November 28, 2024 17:27
Co-authored-by: Tobias Roeser <le.petit.fou@web.de>
Co-authored-by: Tobias Roeser <le.petit.fou@web.de>
Co-authored-by: Tobias Roeser <le.petit.fou@web.de>
Copy link
Member

@jodersky jodersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It might make sense to also mention using separate build files for large projects.

2. *A parallel Mill build is set up for the project.*

** Sub-project `pom.xml` and `build.gradle` files need to be translated into Mill ``Module``s
** Third-party dependencies need to be translated into Mill's def `ivyDeps`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def `ivyDeps` => `def ivyDeps`

@gamlerhart
Copy link
Contributor

One challange I sometimes had to port builds:
The existing build tasks rely on stamping all over the file system to collaborate between parts. Like Maven puts something in one place, then a webpack step picks up from these pieces and places its stuff yet in another place. And so on and so forth. Especially if tools (webpack, bazel, etc) then rely on 'implicit' paths to find configuration etc.

This are portable, but sometimes a bit a head ache. You can give up and do dirty writes outside the Task.dest but then get the more fragile builds. Or be somewhat creative on how to wire the tasks so these stuff works better in isolation.

Anyway, not sure how to formulate this at this point. Probably would need a public example of this tension.

@lihaoyi lihaoyi merged commit a6fe4ee into com-lihaoyi:main Nov 28, 2024
27 checks passed
@lefou lefou added this to the 0.12.4 milestone Nov 28, 2024
jodersky pushed a commit to jodersky/mill that referenced this pull request Jan 14, 2025
This is a manual playbook for running such a migration, that will likely
be useful even in the presence of semi-automated scaffolding generators

Resolves com-lihaoyi#4036

---------

Co-authored-by: Tobias Roeser <le.petit.fou@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a docsite page on manual migration to Mill
4 participants