-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Migrating to Mill
doc page
#4040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I spotted some nits and added suggestions.
Co-authored-by: Tobias Roeser <le.petit.fou@web.de>
Co-authored-by: Tobias Roeser <le.petit.fou@web.de>
Co-authored-by: Tobias Roeser <le.petit.fou@web.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! It might make sense to also mention using separate build files for large projects.
2. *A parallel Mill build is set up for the project.* | ||
|
||
** Sub-project `pom.xml` and `build.gradle` files need to be translated into Mill ``Module``s | ||
** Third-party dependencies need to be translated into Mill's def `ivyDeps` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def `ivyDeps` => `def ivyDeps`
One challange I sometimes had to port builds: This are portable, but sometimes a bit a head ache. You can Anyway, not sure how to formulate this at this point. Probably would need a public example of this tension. |
This is a manual playbook for running such a migration, that will likely be useful even in the presence of semi-automated scaffolding generators Resolves com-lihaoyi#4036 --------- Co-authored-by: Tobias Roeser <le.petit.fou@web.de>
This is a manual playbook for running such a migration, that will likely be useful even in the presence of semi-automated scaffolding generators
Resolves #4036