Only pull compile dependencies during compilation #4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maven offers to add dependencies only at runtime, with its runtime scope. This tries to respect that, by not pulling purely runtime dependencies during compilation.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@alexarchambault could you elaborate a bit on the problem in the PR description and how you are solving it? Some of the code changes seem pretty non-obvious to me |
lihaoyi
reviewed
Nov 27, 2024
| @@ -210,7 +210,7 @@ trait KotlinJsModule extends KotlinModule { outer => | |||
| outputMode = binaryKindToOutputMode(kotlinJsBinaryKind()), | |||
| irClasspath = Some(compile().classes), | |||
| allKotlinSourceFiles = Seq.empty, | |||
| librariesClasspath = compileClasspath(), | |||
| librariesClasspath = upstreamAssemblyClasspath(), | |||
There was a problem hiding this comment.
e.g. what does this have to do with compile time deps?
There was a problem hiding this comment.
I just opened #4039 with solely this change, and more comments / explanations. Basically, the PR here aims at bringing less JARs in class paths made for compilation (like compileClasspath), while the same JARs as currently should be around at runtime.
The linker needs a class path for runtime, so we pass upstreamAssemblyClasspath instead (that contains all dependencies JARs)
There was a problem hiding this comment.
Maybe we could have a new dedicated target, like runDependencyClasspath - with all dependency JARs, including JARs made for runtime, but excluding the current module classes. Or maybe we could just rename upstreamAssemblyClasspath, given it can have a broader uses.
|
To expand the PR description, Android dependencies tend to pull more dependencies at runtime, for example. Compile-time: Runtime: The PR here only passes the first set of dependencies to javac / kotlinc |
lihaoyi
pushed a commit
that referenced
this pull request
Nov 28, 2024
The current code passes a class path made for compile time to the Kotlin JS linker. While it's not a problem with the current main branch that doesn't really make a difference between compile and runtime class paths, this will be a problem with #4028, that can bring less JARs in `compileClasspath` (while all JARs will be around in runtime targets, like `resolvedRunIvyDeps`, like currently)
jodersky
pushed a commit
to jodersky/mill
that referenced
this pull request
Jan 14, 2025
The current code passes a class path made for compile time to the Kotlin JS linker. While it's not a problem with the current main branch that doesn't really make a difference between compile and runtime class paths, this will be a problem with com-lihaoyi#4028, that can bring less JARs in `compileClasspath` (while all JARs will be around in runtime targets, like `resolvedRunIvyDeps`, like currently)
jodersky
pushed a commit
to jodersky/mill
that referenced
this pull request
Jan 14, 2025
Maven offers a way to pull some dependencies only at runtime, via [Maven scopes](https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope). Roughly speaking, in Maven, dependencies can be added - only for compilation (`provided` scope) - for compilation and runtime (`compile` scope - `compile` is for both compile-time and runtime) - only at runtime (`runtime` scope) This matters during dependency management: coursier can pull runtime dependencies or not, for example. Mill already knows about compile-time versus runtime, with `compileIvyDeps` / `ivyDeps` / `runIvyDeps`, which are equivalent to Maven scopes `provided` / `compile` / `runtime`. The PR here asks coursier not to pull runtime dependencies in Mill class paths made for compile-time, like `compileClasspath`. --------- Co-authored-by: Li Haoyi <haoyi.sg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven offers a way to pull some dependencies only at runtime, via Maven scopes.
Roughly speaking, in Maven, dependencies can be added
providedscope)compilescope -compileis for both compile-time and runtime)runtimescope)This matters during dependency management: coursier can pull runtime dependencies or not, for example.
Mill already knows about compile-time versus runtime, with
compileIvyDeps/ivyDeps/runIvyDeps, which are equivalent to Maven scopesprovided/compile/runtime.The PR here asks coursier not to pull runtime dependencies in Mill class paths made for compile-time, like
compileClasspath.