Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIT Use allIvyDeps task where it seems it's meant to be used #3948

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

alexarchambault
Copy link
Collaborator

I was looking at this file, and it feels allIvyDeps was meant to be used in transitiveIvyDeps , but isn't. This fixes that. (Unless allIvyDeps is somehow scheduled for deletion?)

@alexarchambault alexarchambault marked this pull request as draft November 12, 2024 22:51
@lihaoyi
Copy link
Member

lihaoyi commented Nov 13, 2024

Seems reasonable, CC @lefou

@alexarchambault alexarchambault marked this pull request as ready for review November 13, 2024 00:38
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

It was probably an oversight when allIvyDeps was introduced. Looks like we're missing some test coverage.

@lihaoyi lihaoyi merged commit 87707f7 into com-lihaoyi:main Nov 13, 2024
25 checks passed
@lefou lefou added this to the 0.12.3 milestone Nov 13, 2024
@alexarchambault alexarchambault deleted the all-ivy-deps branch November 13, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants