Fix java compile warning, again #3762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
commented
Oct 17, 2024
| @@ -79,7 +79,7 @@ jobs: | |||
|
|
|||
| # Most of these integration tests should not depend on which mode they | |||
| # are run in, so just run them in `local` | |||
| - java-version: '11' | |||
| - java-version: '17' | |||
There was a problem hiding this comment.
The new test emits some benign warnings on Java 11, so just run on java 17 instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3711
I swear this annotation didn't work last time, and the
matchon thediscoveredModuleTypedid. But now they don't. Must have been getting confused by incremental compilationTurns out the discover macro was incorrectly traversing type members and picking up their types, which is why it was appeared in the generated code, so I added a filter to filter them out
Added a test to assert on the full stdout/stderr of a simple mill command run to ensure we don't have stray logs or warnings turning up