Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kotest support for Kotlin/JS #3723

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Add Kotest support for Kotlin/JS #3723

merged 4 commits into from
Oct 14, 2024

Conversation

0xnm
Copy link
Contributor

@0xnm 0xnm commented Oct 12, 2024 •
edited
Loading

This PR brings Kotest test engine support for Kotlin/JS target test execution.

Replaces #3710.

@0xnm 0xnm force-pushed the add-kotest-support-in-kotlinjs branch 2 times, most recently from 69a77b3 to 470d95e Compare October 12, 2024 11:21
@lihaoyi
Copy link
Member

lihaoyi commented Oct 13, 2024

Looks good to me, if I understand correctly the core thing that was missing was the kotestProcessor/kotlincOptions.

Left some nits, but otherwise looks good

@0xnm 0xnm force-pushed the add-kotest-support-in-kotlinjs branch from 470d95e to 4287280 Compare October 13, 2024 08:51
@0xnm
Copy link
Contributor Author

0xnm commented Oct 13, 2024

Actually the 2 pieces were missing:

@lihaoyi lihaoyi merged commit 91ff5f8 into com-lihaoyi:main Oct 14, 2024
24 checks passed
@lihaoyi
Copy link
Member

lihaoyi commented Oct 14, 2024

Thanks @0xnm !

@lefou lefou added this to the 0.12.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihaoyi lihaoyi lihaoyi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@0xnm @lihaoyi @lefou