Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework android support example #3676

Merged
merged 4 commits into from
Oct 5, 2024
Merged

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Oct 5, 2024

Tries to address some of the issues in #3675

  • Various tasks like sdkUrl or buildToolsVersion should be prefixed with android
  • Hardcoded buildToolsVersion defaults to 35.0.0. I suggest to just remove the default.
  • Hardcoded platformsVersion defaults to android-35. We could derive it from buildToolsVersion.
  • In general lots of various paths which are just sub-paths of buildToolsPath have their own tasks. Instead we could have some "config" class, which returns common paths from a buildToolsPath, e.g. by applying a (version specific) layout/sub-paths.
  • AndroidAppModule.androidSdkModule should have the type ModuleRef[AndroidSdkModule].
  • androidResources hardcodes a path to src/main/AndroidManifest.xml. It should either lookup the file from sources task, or be it's own androidManifest: Source task.
  • androidKeystore is probably meant to be a persistent task

@lihaoyi lihaoyi marked this pull request as ready for review October 5, 2024 15:51
@lihaoyi lihaoyi merged commit 070e908 into com-lihaoyi:main Oct 5, 2024
24 checks passed
@lefou lefou added this to the 0.12.0 milestone Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants