Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to address some of the issues in #3675
sdkUrl
orbuildToolsVersion
should be prefixed withandroid
buildToolsVersion
defaults to35.0.0
. I suggest to just remove the default.platformsVersion
defaults toandroid-35
. We could derive it frombuildToolsVersion
.buildToolsPath
have their own tasks. Instead we could have some "config" class, which returns common paths from abuildToolsPath
, e.g. by applying a (version specific) layout/sub-paths.AndroidAppModule.androidSdkModule
should have the typeModuleRef[AndroidSdkModule]
.androidResources
hardcodes a path tosrc/main/AndroidManifest.xml
. It should either lookup the file fromsources
task, or be it's ownandroidManifest: Source
task.androidKeystore
is probably meant to be a persistent task