Switched to external mill-moduledefs dependency #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolgab
reviewed
Oct 19, 2022
| @@ -131,6 +131,9 @@ object Deps { | |||
| val lambdaTest = ivy"de.tototec:de.tobiasroeser.lambdatest:0.7.1" | |||
| val log4j2Core = ivy"org.apache.logging.log4j:log4j-core:2.18.0" | |||
| val osLib = ivy"com.lihaoyi::os-lib:0.8.1" | |||
| val millModuledefsVersion = "0.10.9-alpha-1" | |||
There was a problem hiding this comment.
Why are we using an alpha version?
There was a problem hiding this comment.
It's until we settle on this setup. There will be a stable release (0.10.9) once we do.
Currently (before this PR), Mill also contains a mill-moduledefs artifact, and we need to distinguish it from the other one. Hopefully, once we tag Mill 0.10.9, we can also release it as 0.10.9 without any collisions.
Also, Maven-compatible tools treat 0.10.9-alpha-1 as before 0.10.9, and the meaning of alpha in software development will make it semantically clear. Although in Mill, we used to treat a 0.10.9-1 as after 0.10.9.
lolgab
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second step of externalizing the
moduledefsmodule.The first step was to migrate the current
moduledefscode into an external projectmill-moduledefs.This second step now removes the
moduledefslocal module and refactors the build setup to use the external one. In the external project, we split the shared code and the scalac plugin code into two modules, to respect the different use cases and technical requirements.mill-moduledefsaritfact contains the traits and classes, which need to be on the classpathscalac-mill-moduledefs-pluginartifact contains the scalac plugin, which is distributed for the full compiler version and is only used at compile-timeThe overall goal is, to develop and maintain both projects (Mill and mill-moduledefs) independently. It especially enables proper distribution of the compiler plugin for each full version of the Scala compiler. In addition, we can post-release the now independent mill-moduledefs project for newer Scala versions without bumping the version (if needed), so externally developed Mill plugin projects can safely use newer Scala versions without risking compiler issues.
Review by @lihaoyi