Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BSP JVM Extension support #1849

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Added BSP JVM Extension support #1849

merged 1 commit into from
Apr 26, 2022

Conversation

atty303
Copy link
Contributor

@atty303 atty303 commented Apr 26, 2022

Add support for BSP JVM Extension methods buildTarget/jvmTestEnvironment and buildTarget/jvmRunEnvironment. This will correctly set the classpath for execution and testing from IntelliJ IDEA.

Without this addition, IntelliJ IDEA determines the classpath when executing and testing in a BSP Imported project, but the order of precedence when multiple version Jars exist seems to be different than in Mill. Therefore, binary incompatibility error may occur at runtime.

With this addition, IntelliJ IDEA will add the classpath resolved by Mill to the beginning of the classpath, which is the same behavior as Mill.

It will also reflect forkArgs, forkEnv, and forkWorkingDir as defined in the Mill.

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. Looks good to me. Thank you!

@lefou lefou merged commit 91b92d2 into com-lihaoyi:main Apr 26, 2022
@lefou lefou added this to the after 0.10.3 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants